Change in vdsm[ovirt-3.6]: hsm: Remove image run links in teardownImage

fromani at redhat.com fromani at redhat.com
Tue Feb 16 09:36:15 UTC 2016


Francesco Romani has submitted this change and it was merged.

Change subject: hsm: Remove image run links in teardownImage
......................................................................


hsm: Remove image run links in teardownImage

We were creating the /run/vdsm/sd_uuid/img_uuid in prepareImage, but we
never delete it. This directory (block storage) or link (file storage)
are used by hosted engine VM so it can run without a connected pool.

After vdsm maintenance, file storage domain mount path may change,
invalidating the links. When we create the links, we skip existing
links, assuming that the link target cannot change. Any operation with
the stale link will fail.

We need two fixes:
1. Remove links created in prepareImage during teardownImage
2. For the unlikely case when Vdsm was terminated before teardownImage
   was completed, repair stale links during creation.

This patch fixes the first issue. The second issue is handled in
https://gerrit.ovirt.org/52937.

Change-Id: I4568aaac2ce26c67132a839d95b75dd97bb28f29
Bug-Url: https://bugzilla.redhat.com/1300749
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/53298
Reviewed-by: Adam Litke <alitke at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Simone Tiraboschi <stirabos at redhat.com>
Tested-by: Simone Tiraboschi <stirabos at redhat.com>
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/53559
Reviewed-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/storage/blockSD.py
M vdsm/storage/fileSD.py
M vdsm/storage/sd.py
3 files changed, 32 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Verified; Passed CI tests
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/53559
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4568aaac2ce26c67132a839d95b75dd97bb28f29
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list