Change in vdsm[master]: jsonrpcvdscli: Arrays can be returned from client call

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Tue Feb 16 08:27:47 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: Arrays can be returned from client call
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/53452/1/lib/vdsm/jsonrpcvdscli.py
File lib/vdsm/jsonrpcvdscli.py:

Line 112:             return response.success_raw(resp.result)
Line 113: 
Line 114:         if resp.result and resp.result is not True:
Line 115:             # None is translated to True inside our JSONRPC implementation
Line 116:             if isinstance(resp.result, dict):
please check for list and go with dict as default (else). With current code dict is special case and everything else would use new code
Line 117:                 return response.success(**resp.result)
Line 118:             else:
Line 119:                 return response.success(items=resp.result)
Line 120: 


-- 
To view, visit https://gerrit.ovirt.org/53452
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff22f6d75e9ff3400d1a2a2f64de5c121192e2f2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list