Change in vdsm[ovirt-3.5]: Live Merge: Skip initial extension when base is raw
nsoffer at redhat.com
nsoffer at redhat.com
Mon Feb 15 19:39:16 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Skip initial extension when base is raw
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
-1 for visibility of comments
https://gerrit.ovirt.org/#/c/53110/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 6032: capacity, alloc, physical = self._dom.blockInfo(drive.path, 0)
Line 6033: maxAlloc = min(capacity, maxAlloc)
Line 6034: maxAlloc = maxAlloc * drive.VOLWM_COW_OVERHEAD
Line 6035:
Line 6036: if drive.blockDev and baseFormat == 'COW':
In 3.5 extendDriveVolume is checking for drive.blockDev:
def extendDriveVolume(self, vmDrive, volumeID, curSize):
if not vmDrive.blockDev:
return
So we only need to check for baseFormat == 'COW' here.
If you want to check both, lets do this check before calling blockInfo?
Line 6037: self.extendDriveVolume(drive, baseVolUUID, maxAlloc)
Line 6038:
Line 6039: # Trigger the collection of stats before returning so that callers
Line 6040: # of getVmStats after this returns will see the new job
--
To view, visit https://gerrit.ovirt.org/53110
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If105854174e9fdbc9bad7aef511ff233de8991a3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list