Change in vdsm[master]: Apply storage QoS on running VM

akrejcir at redhat.com akrejcir at redhat.com
Mon Feb 15 17:01:39 UTC 2016


Andrej Krejcir has posted comments on this change.

Change subject: Apply storage QoS on running VM
......................................................................


Patch Set 8:

(6 comments)

https://gerrit.ovirt.org/#/c/52746/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2386: self._devices[hwclass.DISK][:]:
> Works. Better alternative:
Done


Line 2392: asDomainID and hasPoolID and hasImageID and hasVolumeID
> hasAnyId = isVdsmImage(dev)
Done


Line 2394:                     (not hasDomainID or dev.domainID == domainId) and
         :                     (not hasPoolID or dev.poolID == poolId) and
         :                     (not hasImageID or dev.imageID == imageId) and
         :                     (not hasVolumeID or dev.volumeID == volumeId)):
> so it is possible that up to three of those IDs may be False-ish? How so?
I was not sure, if all of them have to be providied to identify a disk.
If yes, I will change this code.


Line 2466:                 domainId = ioTune.get("domainId")
         :                 poolId = ioTune.get("poolId")
         :                 imageId = ioTune.get("imageId")
         :                 volumeId = ioTune.get("volumeId")
> same comment as per line 2394-2397: Doesn't feel right if one or more of th
See previous reply.


Line 2574: res = {'name': device.name, 'path': device.path, 'ioTune': io_tune}
> We don't need this temporary
Done


Line 2580:                     return response.error('noVM')
Line 2581:                 else:
Line 2582:                     return response.error('updateIoTuneErr', e.message)
Line 2583: 
Line 2584:         return {'status': doneCode, 'ioTune': resultList}
> return response.success(ioTune=resultList)
Done
Line 2585: 
Line 2586:     def setIoTune(self, tunables):
Line 2587:         for io_tune_change in tunables:
Line 2588:             device_name = io_tune_change.get('name', None)


-- 
To view, visit https://gerrit.ovirt.org/52746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list