Change in vdsm[master]: virt: Replace vm._dom.XMLDesc(0) with domain descriptor usage

fromani at redhat.com fromani at redhat.com
Mon Feb 15 16:50:47 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: Replace vm._dom.XMLDesc(0) with domain descriptor usage
......................................................................


Patch Set 3: Code-Review-1

(8 comments)

a couple of bugs sneaked into (vm.py:2475 most notably)

https://gerrit.ovirt.org/#/c/52882/3/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 192: self._vm.domain.xml
unfortunately here we need the fresh xml.


Line 327: elf._vm.domain.xml
not sure we can use the cached xml


Line 337: self._vm.domain.xml,
same not sure we can use the cached xml


https://gerrit.ovirt.org/#/c/52882/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1913: self.domain.xml
self._updateDomainDescriptor() ?


Line 2745: self.domain.xml
here we need fresh XML each time, otherwise it is a bug. So let's use

self._updateDomainDescriptor()


Line 2901: self.xml
self._updateDomainDescriptor()


Line 2905: self.xml
self._updateDomainDescriptor()


Line 3109: self.xml
self._updateDomainDescriptor()


-- 
To view, visit https://gerrit.ovirt.org/52882
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic159cb84049d90cdb2a4279a34145462c8ee6be4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list