Change in vdsm[master]: virt: vm.py: Make _updateDomainDescriptor() return new XML

fromani at redhat.com fromani at redhat.com
Mon Feb 15 16:46:01 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: vm.py: Make _updateDomainDescriptor() return new XML
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

-1 for visibility, we need one (minor?) change and this patch is ready.

https://gerrit.ovirt.org/#/c/53372/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3772: 
Line 3773:     def _updateDomainDescriptor(self):
Line 3774:         domainXML = self._dom.XMLDesc(0)
Line 3775:         self.domain = DomainDescriptor(domainXML)
Line 3776:         return domainXML
I'd rather use 

return self.domain.xml.

The end result now is the same, but this enforces and reminds the correct data flow.
Line 3777: 
Line 3778:     def _ejectFloppy(self):
Line 3779:         if 'volatileFloppy' in self.conf:
Line 3780:             utils.rmFile(self.conf['floppy'])


-- 
To view, visit https://gerrit.ovirt.org/53372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic37e3b3eae819a586036dda17021d500f47e4ba7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list