Change in vdsm[master]: numa: move numa related functionality to sitelib

fromani at redhat.com fromani at redhat.com
Mon Feb 15 15:47:23 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: numa: move numa related functionality to sitelib
......................................................................


Patch Set 5: Code-Review+1

(3 comments)

looks really good and nicer than before. Just few inline comments. Partial ACK.

https://gerrit.ovirt.org/#/c/53286/5/lib/vdsm/numa.py
File lib/vdsm/numa.py:

Line 45:         cpus = []
       :         for cpu in cell.iter(tag='cpu'):
       :             cpus.append(int(cpu.get('id')))
just wondering: perhaps a list comprehension is a bit clearer here?


Line 48: cpus
so it seems we don't need the `cpus' temporary value


Line 64: cellMemInfo
pep8 names please


-- 
To view, visit https://gerrit.ovirt.org/53286
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dffad8663ca50a67f117b1c74d4459e667d9f43
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list