Change in vdsm[master]: hsm: Remove image run links in teardownImage

danken at redhat.com danken at redhat.com
Mon Feb 15 13:48:59 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: hsm: Remove image run links in teardownImage
......................................................................


hsm: Remove image run links in teardownImage

We were creating the /run/vdsm/sd_uuid/img_uuid in prepareImage, but we
never delete it. This directory (block storage) or link (file storage)
are used by hosted engine VM so it can run without a connected pool.

After vdsm maintenance, file storage domain mount path may change,
invalidating the links. When we create the links, we skip existing
links, assuming that the link target cannot change. Any operation with
the stale link will fail.

We need two fixes:
1. Remove links created in prepareImage during teardownImage
2. For the unlikely case when Vdsm was terminated before teardownImage
   was completed, repair stale links during creation.

This patch fixes the first issue. The second issue is handled in
https://gerrit.ovirt.org/52937.

Change-Id: I4568aaac2ce26c67132a839d95b75dd97bb28f29
Bug-Url: https://bugzilla.redhat.com/1300749
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/53298
Reviewed-by: Adam Litke <alitke at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Simone Tiraboschi <stirabos at redhat.com>
Tested-by: Simone Tiraboschi <stirabos at redhat.com>
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/storage/blockSD.py
M vdsm/storage/fileSD.py
M vdsm/storage/sd.py
3 files changed, 32 insertions(+), 1 deletion(-)

Approvals:
  Adam Litke: Looks good to me, but someone else must approve
  Nir Soffer: Verified
  Simone Tiraboschi: Verified; Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Allon Mureinik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/53298
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4568aaac2ce26c67132a839d95b75dd97bb28f29
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list