Change in vdsm[master]: Advertise aggregator ID in bonding interfaces

danken at redhat.com danken at redhat.com
Mon Feb 15 12:17:32 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: Advertise aggregator ID in bonding interfaces
......................................................................


Patch Set 14: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/53100/14/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 2836:         with veth_pair() as (n1, n2), veth_pair() as (n3, n4):
         :             nics = [n1, n2, n3, n4]
         :             bonds = {BONDING_NAME: (n1, n3), BONDING_NAME + "0": (n2, n4)}
         :             for bond, pair in six.iteritems(bonds):
         :                 bonding = {'nics': pair}
         :                 bonding.update({'options': bond_options})
         :                 status, msg = self.setupNetworks(
         :                     {},
         :                     {bond: bonding},
         :                     NOCHK)
         :                 self.assertEqual(status, SUCCESS, msg)
         :                 self.assertBondExists(bond, pair)
         : 
         :             status, msg, info = self.vdsm_net.getVdsCapabilities()
this preparation can be placed in a helper function, to be called by two separate tests, one for mode4 and another for mode0. As Edy suggested below, it can be implemented as a context manager, which would be cool.


-- 
To view, visit https://gerrit.ovirt.org/53100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85267967c9cb1b0a626d91cb1953361ed4de727a
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman <sshnaidm at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Sagi Shnaidman <sshnaidm at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list