Change in vdsm[master]: vdsm: added decorator to host uuid function
danken at redhat.com
danken at redhat.com
Mon Feb 15 11:02:10 UTC 2016
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: added decorator to host uuid function
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
thanks for your patch. there are two (minor) comments, though.
Can you specify HOW you have verified this patch?
https://gerrit.ovirt.org/#/c/53499/1/lib/vdsm/host.py
File lib/vdsm/host.py:
Line 33: __hostUUID
now that the variable is not global, we do not need to keep the funny __ prefix. Please rename it to host_uuid.
--
To view, visit https://gerrit.ovirt.org/53499
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42b725075a14bb090e9dd0aa429fffe537ccfed9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <irit.goihman at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Irit Goihman <irit.goihman at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list