Change in vdsm[master]: vdsm: added decorator to host uuid function

ybronhei at redhat.com ybronhei at redhat.com
Mon Feb 15 09:30:46 UTC 2016


Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm: added decorator to host uuid function
......................................................................


Patch Set 1:

(1 comment)

Can you push the patch again without the Draft?

https://gerrit.ovirt.org/#/c/53499/1/lib/vdsm/host.py
File lib/vdsm/host.py:

Line 21: 
Line 22: from vdsm.utils import memoized
Line 23: 
Line 24: import os
Line 25: import logging
we keep the imports in order such that buildin imports before project internals - so can you please move the import under the logging ?
Line 26: from .commands import execCmd
Line 27: from . import constants
Line 28: from . import cpuarch
Line 29: 


-- 
To view, visit https://gerrit.ovirt.org/53499
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42b725075a14bb090e9dd0aa429fffe537ccfed9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <irit.goihman at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Irit Goihman <irit.goihman at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list