Change in vdsm[master]: netinfo: tighten exception handling in getIfaceCfg

danken at redhat.com danken at redhat.com
Mon Feb 15 07:27:10 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: tighten exception handling in getIfaceCfg
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/53470/2/lib/vdsm/netinfo/misc.py
File lib/vdsm/netinfo/misc.py:

Line 40: getIfaceCfg
could you eliminate instead all users of this function, except the one in netinfo.cache? I think we can read all needed data straight from cache.


Line 51:             configurator = config.get('vars', 'net_configurator')
Line 52:             if configurator == 'ifcfg':
Line 53:                 logging.warning('ifcfg file for %s not found.', iface)
Line 54:         else:
Line 55:             raise
this can cause getCaps to explode due to a single bad-permission file. not good.
Line 56:     return ifaceCfg
Line 57: 
Line 58: 
Line 59: def visible_devs(predicate):


-- 
To view, visit https://gerrit.ovirt.org/53470
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6db32b1ad8aaa5e3543e8a19e76a347409811b0b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list