Change in vdsm[master]: coverage: Add vdsm-coverage sub package

sbonazzo at redhat.com sbonazzo at redhat.com
Mon Feb 15 06:26:10 UTC 2016


Sandro Bonazzola has posted comments on this change.

Change subject: coverage: Add vdsm-coverage sub package
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/49807/5/vdsm.spec.in
File vdsm.spec.in:

Line 1499: %{_datadir}/%{vdsm_name}/gluster/tasks.py*
Line 1500: %endif
Line 1501: 
Line 1502: %files coverage
Line 1503: %defattr(-, root, root, -)
> We use this everywhere (e.g. line 1487) - why is this not needed?
since RPM 4.4 above line is set by default by rpm itself.
See for reference:
 - https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_Permissions
 - https://fedorahosted.org/fpc/ticket/77

So unless you build for EPEL 4, the line can be omitted.
Line 1504: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/coverage.conf
Line 1505: %config(noreplace) %{_sysconfdir}/sysconfig/vdsm
Line 1506: 
Line 1507: %changelog


-- 
To view, visit https://gerrit.ovirt.org/49807
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95454731ca1c19e6f01417d2c26023e7c748365a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Petr Balogh <pbalogh at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list