Change in vdsm[master]: coverage: Add vdsm-coverage sub package
nsoffer at redhat.com
nsoffer at redhat.com
Sun Feb 14 17:45:42 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: coverage: Add vdsm-coverage sub package
......................................................................
Patch Set 5:
(7 comments)
https://gerrit.ovirt.org/#/c/49807/5/Makefile.am
File Makefile.am:
Line 1: #
> 2008-2016
Will update
Line 2: # Copyright 2008-2012 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
https://gerrit.ovirt.org/#/c/49807/5/build-aux/Makefile.subs
File build-aux/Makefile.subs:
Line 1: #
> 2008-2016
Will update
Line 2: # Copyright 2008-2012 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
https://gerrit.ovirt.org/#/c/49807/5/configure.ac
File configure.ac:
Line 1: #
> 2008-2016
Will update
Line 2: # Copyright 2008-2012 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
https://gerrit.ovirt.org/#/c/49807/5/coverage/Makefile.am
File coverage/Makefile.am:
Line 1: #
Line 2: # Copyright 2015 Red Hat, Inc.
> 2015-2016
Will update
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
https://gerrit.ovirt.org/#/c/49807/5/coverage/README.md
File coverage/README.md:
Line 4:
Line 5: ## Files
Line 6:
Line 7: - /etc/vdsm/coverage.conf - coverage configuration file
Line 8: - /etc/sysconfig/vdsm - environment file for enabling coverage
> is /etc/sysconfig/vdsm ok for debian as well?
I don't have any idea, our debian packager should tell use what is the correct place.
Line 9:
Line 10: ## Recording code coverage
Line 11:
Line 12: 1. Enable coverage in vdsm.conf:
https://gerrit.ovirt.org/#/c/49807/5/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 1: #
> 2011-2016
Will update
Line 2: # Copyright 2011-2013 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
https://gerrit.ovirt.org/#/c/49807/5/vdsm.spec.in
File vdsm.spec.in:
Line 1499: %{_datadir}/%{vdsm_name}/gluster/tasks.py*
Line 1500: %endif
Line 1501:
Line 1502: %files coverage
Line 1503: %defattr(-, root, root, -)
> above line is not useful if not building for epel5
We use this everywhere (e.g. line 1487) - why is this not needed?
Line 1504: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/coverage.conf
Line 1505: %config(noreplace) %{_sysconfdir}/sysconfig/vdsm
Line 1506:
Line 1507: %changelog
--
To view, visit https://gerrit.ovirt.org/49807
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95454731ca1c19e6f01417d2c26023e7c748365a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Petr Balogh <pbalogh at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list