Change in vdsm[master]: Advertise aggregator ID in bonding interfaces

danken at redhat.com danken at redhat.com
Sat Feb 13 05:40:08 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: Advertise aggregator ID in bonding interfaces
......................................................................


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/53100/12/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 2827: 
Line 2828:     @permutations([[{}], [{'options': 'mode=4 lacp_rate=1 miimon=100'}]])
Line 2829:     @cleanupNet
Line 2830:     @ValidateRunningAsRoot
Line 2831:     def test_bond_mode4_caps_aggregator_id(self, bond_options):
> still, using a double-veth test smells more realistic. if you have tried it
from the command line, using two veth pairs worked really nicely.

ip link add vetha1 type veth peer name vetha2
ip link add vethb1 type veth peer name vethb2
ip link add bond1 type bond
ip link add bond2 type bond

echo 4 > /sys/class/net/bond1/bonding/mode
echo 100 > /sys/class/net/bond1/bonding/miimon
echo +vethb1 > /sys/class/net/bond1/bonding/slaves
echo +vetha1 > /sys/class/net/bond1/bonding/slaves
ip link set up bond1

echo 4 > /sys/class/net/bond2/bonding/mode
echo 100 > /sys/class/net/bond2/bonding/miimon
echo +vetha2 > /sys/class/net/bond2/bonding/slaves
echo +vethb2 > /sys/class/net/bond2/bonding/slaves
ip link set up bond2

cat /sys/class/net/bond1/bonding/ad_partner_mac
# 1a:be:75:77:66:7c
cat /sys/class/net/bond2/address
# 1a:be:75:77:66:7c

ip link del vetha1
ip link del vethb1
ip link del bond1
ip link del bond2
Line 2832:         with dummyIf(3) as nics:
Line 2833:             bonding = {'nics': nics[:2]}
Line 2834:             bonding.update(bond_options)
Line 2835:             status, msg = self.setupNetworks(


-- 
To view, visit https://gerrit.ovirt.org/53100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85267967c9cb1b0a626d91cb1953361ed4de727a
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman <sshnaidm at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Sagi Shnaidman <sshnaidm at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list