Change in vdsm[master]: Advertise aggregator ID in bonding interfaces
danken at redhat.com
danken at redhat.com
Fri Feb 12 07:34:55 UTC 2016
Dan Kenigsberg has posted comments on this change.
Change subject: Advertise aggregator ID in bonding interfaces
......................................................................
Patch Set 11: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/53100/11/lib/vdsm/netinfo/cache.py
File lib/vdsm/netinfo/cache.py:
Line 73: _
a public function must be named as such.
https://gerrit.ovirt.org/#/c/53100/11/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 2831: mode4
it would be much clearer to pass bond_options here.
Line 2829: @cleanupNet
Line 2830: @ValidateRunningAsRoot
Line 2831: def test_bond_mode4_caps_aggregator_id(self, mode4):
Line 2832: with dummyIf(3) as nics:
Line 2833: bonding = {'nics': nics[:2]}
even an all-zero partner mac seems more informative than a missing one. could you share the veth_pair() test of yours?
Line 2834: bonding.update(mode4)
Line 2835: status, msg = self.setupNetworks(
Line 2836: {},
Line 2837: {BONDING_NAME: bonding},
Line 2852: 'N/A'
'N/A' should not be mentioned in Vdsm API. ag_id should be numeric or missing from the report.
--
To view, visit https://gerrit.ovirt.org/53100
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85267967c9cb1b0a626d91cb1953361ed4de727a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman <sshnaidm at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Sagi Shnaidman <sshnaidm at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list