Change in vdsm[master]: Advertise aggregator ID in bonding interfaces

sshnaidm at redhat.com sshnaidm at redhat.com
Thu Feb 11 16:25:36 UTC 2016


Sagi Shnaidman has posted comments on this change.

Change subject: Advertise aggregator ID in bonding interfaces
......................................................................


Patch Set 9:

(2 comments)

https://gerrit.ovirt.org/#/c/53100/9/lib/vdsm/netinfo/nics.py
File lib/vdsm/netinfo/nics.py:

Line 80:         with open(path, "r") as f:
Line 81:             return f.read().strip()
Line 82: 
Line 83: 
Line 84: def get_bond_agg_info(nic_name):
> I am not sure about the other function, but this one should clearly sit in 
moved everything to bonding, please check
Line 85:     agg_id_path = os.path.join(NET_PATH, nic_name, 'bonding', 'ad_aggregator')
Line 86:     ad_mac_path = os.path.join(NET_PATH, nic_name, 'bonding', 'ad_partner_mac')
Line 87:     return {
Line 88:         'ad_aggregator_id': _file_value(agg_id_path),


https://gerrit.ovirt.org/#/c/53100/9/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 2828:     @permutations([[{}], [{'options': 'mode=4 lacp_rate=1 miimon=100'}]])
Line 2829:     @cleanupNet
Line 2830:     @ValidateRunningAsRoot
Line 2831:     def test_bond_mode4_caps_aggregator_id(self, mode4):
Line 2832:         with dummyIf(3) as nics:
> Edy had a nice idea: can you create
I tried, it didn't work. It has "00:00:00:.." as partner mac.
Line 2833:             bonding = {'nics': nics[:2]}
Line 2834:             bonding.update(mode4)
Line 2835:             status, msg = self.setupNetworks(
Line 2836:                 {},


-- 
To view, visit https://gerrit.ovirt.org/53100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85267967c9cb1b0a626d91cb1953361ed4de727a
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman <sshnaidm at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Sagi Shnaidman <sshnaidm at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list