Change in vdsm[master]: numa: get distance information from libvirt
fromani at redhat.com
fromani at redhat.com
Thu Feb 11 13:22:55 UTC 2016
Francesco Romani has posted comments on this change.
Change subject: numa: get distance information from libvirt
......................................................................
Patch Set 3: Code-Review+1
(4 comments)
nice work. Preliminary partial ACK, few (minor) comments inside
https://gerrit.ovirt.org/#/c/53285/3//COMMIT_MSG
Commit Message:
Line 11: patch does separate pass over libvirt capabilities, it opens up
Line 12: possibility for single pass in future of the series.
Line 13:
Line 14: Change-Id: I80b423e27fa37bc49388cca72785b081e4365e69
Line 15: Bug-Url: https://bugzilla.redhat.com/??????
Do we need one?
https://gerrit.ovirt.org/#/c/53285/3/vdsm/caps.py
File vdsm/caps.py:
Line 253: if capabilities is None:
Line 254: capabilities = _getCapsXMLStr()
Line 255: caps = ET.fromstring(capabilities)
Line 256: cells = caps.find('host').find('.//cells').findall('cell')
Line 257: distances = {}
minor: maybe defaultdict(list) ?
your call, I don't mind either way
Line 258: for cell in cells:
Line 259: cellIndex = cell.get('id')
Line 260: distances[cellIndex] = []
Line 261: for sibling in cell.find('distances').findall('sibling'):
Line 259: cellIndex
same as below
Line 262: sibling.get('value')
this will be a str, right? do we need to make it an int?
--
To view, visit https://gerrit.ovirt.org/53285
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80b423e27fa37bc49388cca72785b081e4365e69
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list