Change in vdsm[master]: Dynamic load of supervdsm_api funcs

danken at redhat.com danken at redhat.com
Thu Feb 11 13:22:47 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: Dynamic load of supervdsm_api funcs
......................................................................


Patch Set 16: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/52875/16/vdsm/supervdsm_api/network.py
File vdsm/supervdsm_api/network.py:

Line 26: def restoreNetworks(*args, **kwrags):
Line 27:     return restore(*args, **kwrags)
Line 28: 
Line 29: 
Line 30: expose(setupNetworks)
> Avoids an indirection and it has less lines of code :)
I'm happy with the current code.


-- 
To view, visit https://gerrit.ovirt.org/52875
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67a1c349c15a03ba54788ffafd0c5b9d30ff7037
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list