Change in vdsm[master]: virt: recovery: use proper os.path functions

fromani at redhat.com fromani at redhat.com
Thu Feb 11 11:34:35 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: recovery: use proper os.path functions
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/53053/1/vdsm/virt/recovery.py
File vdsm/virt/recovery.py:

Line 219:         except ValueError:
Line 220:             # If file is missing type extention - ignore it
Line 221:             pass
Line 222:         else:
Line 223:             if fileType == ".recovery" and vmId not in cif.vmContainer:
> actaully,
Good point, let's reduce the code duplication.
Line 224:                 cif.log.debug("cleaning old file " + f)


-- 
To view, visit https://gerrit.ovirt.org/53053
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93935e32e4169efa8f03be1bfc1d7021374ee68e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list