Change in vdsm[master]: network: fix dhclient return code catching

danken at redhat.com danken at redhat.com
Thu Feb 11 08:38:57 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: network: fix dhclient return code catching
......................................................................


network: fix dhclient return code catching

configurators/__init__.py:runDhclient() expects dhclient.start() to
always return three values (rc, out, err). Problem occurs when
we call dhclient.start() with blockingdhcp=False and only None is
returned.

Fix this with storing return values in one variable and accessing
rc with [0].

Change-Id: I3fcc04504267b2d65a2aba7c5a5ebd74ed049582
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/53049
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/network/configurators/__init__.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/53049
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3fcc04504267b2d65a2aba7c5a5ebd74ed049582
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list