Change in vdsm[master]: network: fix dhclient return code

phoracek at redhat.com phoracek at redhat.com
Wed Feb 10 11:31:16 UTC 2016


Petr Horáček has posted comments on this change.

Change subject: network: fix dhclient return code
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/53049/1/lib/vdsm/network/configurators/dhclient.py
File lib/vdsm/network/configurators/dhclient.py:

Line 74:             t = threading.Thread(target=self._dhclient, name='vdsm-dhclient-%s'
Line 75:                                  % self.iface)
Line 76:             t.daemon = True
Line 77:             t.start()
Line 78:             return 0, [], []
> this semantics of this function is horrible, but your change do not make it
Done
Line 79: 
Line 80:     def shutdown(self):
Line 81:         try:
Line 82:             pid = int(open(self.pidFile).readline().strip())


-- 
To view, visit https://gerrit.ovirt.org/53049
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3fcc04504267b2d65a2aba7c5a5ebd74ed049582
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list