Change in vdsm[master]: Live Merge: Skip initial extension when base is raw

nsoffer at redhat.com nsoffer at redhat.com
Tue Feb 9 19:46:53 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: Live Merge: Skip initial extension when base is raw
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Looks good, minor issue about checking for cow format.

https://gerrit.ovirt.org/#/c/53317/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4883:         # reported by libvirt so we must do the full extension up front.  In
Line 4884:         # the worst case, the allocated size of 'base' should be increased by
Line 4885:         # the allocated size of 'top' plus one additional chunk to accomodate
Line 4886:         # additional writes to 'top' during the live merge operation.
Line 4887:         if drive.chunked and baseInfo['format'] != 'RAW':
Why not:

    and baseInfo['format'] == "COW"

In chunked, we check:

    return self.blockDev and self.format == "cow"

Better use == cow everywhere. If we introduce a third format, we don't want to do there stuff that is correct only for cow format.
Line 4888:             capacity, alloc, physical = self._getExtendInfo(drive)
Line 4889:             baseSize = int(baseInfo['apparentsize'])
Line 4890:             topSize = int(topInfo['apparentsize'])
Line 4891:             maxAlloc = baseSize + topSize


-- 
To view, visit https://gerrit.ovirt.org/53317
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If105854174e9fdbc9bad7aef511ff233de8991a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list