Change in vdsm[master]: virt: s/vm._dom.XMLDesc(0)/vm.xml/g

nsoffer at redhat.com nsoffer at redhat.com
Tue Feb 9 17:26:27 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: virt: s/vm._dom.XMLDesc(0)/vm.xml/g
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/52882/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3745
Line 3746
Line 3747
Line 3748
Line 3749
Here we don't need to use the property


Line 3732:     @property
Line 3733:     def name(self):
Line 3734:         return self.conf['vmName']
Line 3735: 
Line 3736:     @property
> I wonder about relative popularity of properties in Vdsm.  IMHO they have t
the flags argument to XMLDesc it is opional, so we really should not use it. It would be nice to eliminate it in a separate patch.

self.xml is little too easy to use - we have self.domain for caching libvirt xml. I don't think we should provide another way to access uncached xml.

Places that should access updated xml from libvirt should update self.domain and use self.domain.xml.
Line 3737:     def xml(self):
Line 3738:         return self._dom.XMLDesc(0)
Line 3739: 
Line 3740:     def _getPid(self):


-- 
To view, visit https://gerrit.ovirt.org/52882
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic159cb84049d90cdb2a4279a34145462c8ee6be4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list