Change in vdsm[master]: hooks: ovs: enable auto-attach mapping

edwardh at redhat.com edwardh at redhat.com
Tue Feb 9 15:35:55 UTC 2016


Edward Haas has posted comments on this change.

Change subject: hooks: ovs: enable auto-attach mapping
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/51859/1/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
File vdsm_hooks/ovs/ovs_before_network_setup_ovs.py:

Line 148:     return ['--', 'set', 'Bridge', BRIDGE_NAME,
Line 149:             'stp_enable=%s' % str(stp).lower()]
Line 150: 
Line 151: 
Line 152: def _set_aa_mapping(network, attrs, running_config):
> We use this template:
Many functions are a bless, so say SOLID principles.
It should be very easy and fast to read, if possible.
Anyway, it is up to you..

In general, I prefer good names with focused functions over comments.
Line 153:     """Handle OVS Auto-Attach mapping"""
Line 154:     command = []
Line 155:     init_sid = rget(running_config.networks, (network, 'custom', 'ovs_aa_sid'))
Line 156:     init_vlan = rget(running_config.networks, (network, 'vlan'))


-- 
To view, visit https://gerrit.ovirt.org/51859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list