Change in vdsm[master]: Dynamic load of supervdsm_api funcs

edwardh at redhat.com edwardh at redhat.com
Tue Feb 9 15:24:15 UTC 2016


Edward Haas has posted comments on this change.

Change subject: Dynamic load of supervdsm_api funcs
......................................................................


Patch Set 13: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/52875/13/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 231
Line 232
Line 233
Line 234
Line 235
> but in this patch set the module is empty
It's not empty, the exposed methods (from the import) are processed.
There is a problem there with the restore() method, I added a remark there.


Line 301
Line 302
Line 303
Line 304
Line 305
> As above
As explained, it is exposed by importing the method.


https://gerrit.ovirt.org/#/c/52875/13/vdsm/supervdsm_api/network.py
File vdsm/supervdsm_api/network.py:

Line 23: restore
.. as restoreNetworks

To keep the same api.


-- 
To view, visit https://gerrit.ovirt.org/52875
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67a1c349c15a03ba54788ffafd0c5b9d30ff7037
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list