Change in vdsm[master]: net: api: _netinfo is always passed to _add_missing_networks

phoracek at redhat.com phoracek at redhat.com
Tue Feb 9 14:43:33 UTC 2016


Petr Horáček has uploaded a new change for review.

Change subject: net: api: _netinfo is always passed to _add_missing_networks
......................................................................

net: api: _netinfo is always passed to _add_missing_networks

_add_missing_networks is used only on one place and _netinfo
parameter is always passed to it.

Change-Id: Ia78f42433907b4dd81222649ab3984b49ebada08
Signed-off-by: Petr Horáček <phoracek at redhat.com>
---
M lib/vdsm/network/api.py
1 file changed, 2 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/53300/1

diff --git a/lib/vdsm/network/api.py b/lib/vdsm/network/api.py
index d68af8b..80dc95d 100755
--- a/lib/vdsm/network/api.py
+++ b/lib/vdsm/network/api.py
@@ -732,13 +732,9 @@
         topNetDev.remove()
 
 
-def _add_missing_networks(configurator, networks, bondings, logger,
-                          _netinfo=None):
+def _add_missing_networks(configurator, networks, bondings, logger, _netinfo):
     # We need to use the newest host info
-    if _netinfo is None:
-        _netinfo = CachingNetInfo()
-    else:
-        _netinfo.updateDevices()
+    _netinfo.updateDevices()
 
     for network, attrs in networks.iteritems():
         if 'remove' in attrs:


-- 
To view, visit https://gerrit.ovirt.org/53300
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia78f42433907b4dd81222649ab3984b49ebada08
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>


More information about the vdsm-patches mailing list