Change in vdsm[master]: network: fix dhclient return code

phoracek at redhat.com phoracek at redhat.com
Tue Feb 9 13:20:47 UTC 2016


Petr Horáček has uploaded a new change for review.

Change subject: network: fix dhclient return code
......................................................................

network: fix dhclient return code

Functions' output should be consistent.

configurators/__init__.py:runDhclient() expects dhclient.start()
to always return iterable of three values, but when we set blockingdhcp
to False, start() returns just None and vdsm fails.

Change-Id: I3fcc04504267b2d65a2aba7c5a5ebd74ed049582
Signed-off-by: Petr Horáček <phoracek at redhat.com>
---
M lib/vdsm/network/configurators/dhclient.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/53049/1

diff --git a/lib/vdsm/network/configurators/dhclient.py b/lib/vdsm/network/configurators/dhclient.py
index 3e8f1fc..961bb8f 100644
--- a/lib/vdsm/network/configurators/dhclient.py
+++ b/lib/vdsm/network/configurators/dhclient.py
@@ -75,6 +75,7 @@
                                  % self.iface)
             t.daemon = True
             t.start()
+            return 0, [], []
 
     def shutdown(self):
         try:


-- 
To view, visit https://gerrit.ovirt.org/53049
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3fcc04504267b2d65a2aba7c5a5ebd74ed049582
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list