Change in vdsm[master]: Dynamic load of supervdsm_api funcs

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Tue Feb 9 11:36:24 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: Dynamic load of supervdsm_api funcs
......................................................................


Patch Set 13: Code-Review-1

(4 comments)

https://gerrit.ovirt.org/#/c/52875/13/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 231
Line 232
Line 233
Line 234
Line 235
Do we really want to remove those methods? network module is empty in this patch set.


Line 301
Line 302
Line 303
Line 304
Line 305
As above


https://gerrit.ovirt.org/#/c/52875/13/vdsm/supervdsm_api/network.py
File vdsm/supervdsm_api/network.py:

Line 18: #
Why do we need this module?


https://gerrit.ovirt.org/#/c/52875/13/vdsm/supervdsm_api/test_api.py
File vdsm/supervdsm_api/test_api.py:

Line 14: # along with this program; if not, write to the Free Software
Line 15: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
Line 16: #
Line 17: # Refer to the README and COPYING files for full details of the license
Line 18: #
The name of this module still use _api.

Why do we need test module in production code?
Line 19: from __future__ import absolute_import
Line 20: 
Line 21: 
Line 22: def ping(*args, **kwargs):


-- 
To view, visit https://gerrit.ovirt.org/52875
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67a1c349c15a03ba54788ffafd0c5b9d30ff7037
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list