Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

danken at redhat.com danken at redhat.com
Mon Feb 8 16:15:06 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: Using pkgutil instead of redundant private funcs in configurator
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/53214/2/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 55: #
Line 56: # Default implementation follows;
Line 57: #
Line 58: 
Line 59: 
unrelated change
Line 60: def _getrequires(module):
Line 61:     """Return a set of module names required by this module.
Line 62: 
Line 63:     Those modules will be included even if not provided in --module.


-- 
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list