Change in vdsm[master]: Adding vdsm functional tests

danken at redhat.com danken at redhat.com
Mon Feb 8 16:12:21 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: Adding vdsm functional tests
......................................................................


Patch Set 52:

(1 comment)

https://gerrit.ovirt.org/#/c/48268/52/automation/check-merged.sh
File automation/check-merged.sh:

Line 64: virsh -c qemu:///system list || :
why do you want to list currently-running VMs? for debug? why do you want to continue if virsh explodes? why's the sleep?

The comments above these 2 lines do not seem related :-/


-- 
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c
Gerrit-PatchSet: 52
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Caro <dcaro at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list