Change in vdsm[master]: ssl: common name differences on f23

danken at redhat.com danken at redhat.com
Mon Feb 8 15:50:12 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: ssl: common name differences on f23
......................................................................


Patch Set 1: -Code-Review

(1 comment)

https://gerrit.ovirt.org/#/c/53231/1/tests/integration/jsonRpcHelper.py
File tests/integration/jsonRpcHelper.py:

Line 87:     sslctx = DEAFAULT_SSL_CONTEXT if ssl else None
Line 88:     reactor = Reactor()
Line 89:     acceptor = MultiProtocolAcceptor(
Line 90:         reactor,
Line 91:         "::1",
> I had certs generated on f22 for long time so I didn't see any issues on my
so the commit message should be amended. we do not think the fix is related to f23, right?

and yes, we should make sure that the cert are regenerated when needed. maybe

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 87abb5d..675744d 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -240,7 +240,7 @@ dist_vdsmtests_SCRIPTS = \
 all-local: \
        $(nodist_vdsmtests_PYTHON)
 
-server.crt server.csr server.key other.crt other.csr other.key:
+server.crt server.csr server.key other.crt other.csr other.key: makecert.sh
        ./makecert.sh
 
 # crossImportsTests.py has to be run separate due to different tests which
Line 92:         0,
Line 93:         sslctx,
Line 94:     )
Line 95: 


-- 
To view, visit https://gerrit.ovirt.org/53231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibce231d3f5607b6f8c34b267d350039b7a6539b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list