Change in vdsm[master]: Dynamic load of supervdsm_api funcs

edwardh at redhat.com edwardh at redhat.com
Mon Feb 8 15:16:50 UTC 2016


Edward Haas has posted comments on this change.

Change subject: Dynamic load of supervdsm_api funcs
......................................................................


Patch Set 12:

(2 comments)

Very nice, I like.

https://gerrit.ovirt.org/#/c/52875/12/vdsm/supervdsm_api/network.py
File vdsm/supervdsm_api/network.py:

Line 19: # pylint: disable=W0611
Can be removed


Line 22: # exposing import funcs
It is not trivial enough to deserve more explanation.
Maybe even giving a template example.


-- 
To view, visit https://gerrit.ovirt.org/52875
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67a1c349c15a03ba54788ffafd0c5b9d30ff7037
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list