Change in vdsm[master]: xmlrpc: retry when flushing socket

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon Feb 8 12:48:06 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: xmlrpc: retry when flushing socket
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/47637/6/vdsm/rpc/bindingxmlrpc.py
File vdsm/rpc/bindingxmlrpc.py:

Line 298:                             # such as the local error ECONNABORTED.
Line 299:                             break
Line 300:                         except SSL.SSLError as e:
Line 301:                             if e.message != 'bad write retry':
Line 302:                                 break
> this sounds more easier to understand ..
In this code change we want to make sure that flush succeeded. async io require from us to retry so we need to make sure to follow it. Please note that it is last thing we do before closing a socket and logging has no value here.

1. when socket is closed we break
2. if sslerror we break unless we are asked to retry.


We do we want to over complicate this simple logic?
Line 303: 
Line 304:                 self.wfile.close()
Line 305:                 self.rfile.close()
Line 306:                 threadLocal.client = None


-- 
To view, visit https://gerrit.ovirt.org/47637
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52dd6ad304a82ff6c8d3dff12a38269684abf055
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list