Change in vdsm[master]: contrib: schema converter

ybronhei at redhat.com ybronhei at redhat.com
Mon Feb 8 10:10:23 UTC 2016


Yaniv Bronhaim has posted comments on this change.

Change subject: contrib: schema converter
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/52864/2//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2016-01-28 15:10:47 +0100
Line 4: Commit:     pkliczewski <piotr.kliczewski at gmail.com>
Line 5: CommitDate: 2016-02-05 13:56:09 +0100
Line 6: 
Line 7: contrib: schema converter
> the name is used during build and it was intentionally created in that way.
so say it here, or do it separately . I'd rename the module name. dan will never merge patch that says schema converter which also moves 100+ lines of code
Line 8: 
Line 9: 
Line 10: Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92


-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list