Change in vdsm[master]: numa: only use libvirt for memory info
fromani at redhat.com
fromani at redhat.com
Mon Feb 8 09:38:08 UTC 2016
Francesco Romani has posted comments on this change.
Change subject: numa: only use libvirt for memory info
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
partial ACK. Conceptually and codewise looks fine, but I'd like better dependency tracking.
https://gerrit.ovirt.org/#/c/53091/4//COMMIT_MSG
Commit Message:
Line 7: numa: only use libvirt for memory info
Line 8:
Line 9: Current code queries memory usage via libvirt or /proc/meminfo,
Line 10: depending on the state of machine's numa support. For some time,
Line 11: (guaranteed 7.0+) even machines without direct numa support do
can we depend on a specific libvirt/kernel version to make sure?
Let's update the debian and rpm data accordingly
Line 12: expose a single node that we can query.
Line 13:
Line 14: This patch removes the 'UMA' (unified memory access) code branch
Line 15: and uses libvirt for all numa memory queries.
https://gerrit.ovirt.org/#/c/53091/4/tests/samplingTests.py
File tests/samplingTests.py:
Line 188:
Line 189: def _monkeyPatchedMemorySample(self, freeMemory, totalMemory):
Line 190: node_id, cpu_id = 0, 0
Line 191:
Line 192: def fakeMemoryStats(_):
maybe *args or the real name or even `unused' is less easy to miss.
Line 193: return {
Line 194: 'free': freeMemory,
Line 195: 'total': totalMemory
Line 196: }
--
To view, visit https://gerrit.ovirt.org/53091
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b5594a71047aae53374e4af5da95e3cd56f3835
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list