Change in vdsm[master]: numa: only use libvirt for memory info

mpolednik at redhat.com mpolednik at redhat.com
Mon Feb 8 09:31:57 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: numa: only use libvirt for memory info
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/53091/3/tests/capsTests.py
File tests/capsTests.py:

Line 303:                     'pc-i440fx-rhel7.0.0']
Line 304:         self.assertEqual(expected, result)
Line 305: 
Line 306:     @MonkeyPatch(caps, 'getMemoryStatsByNumaCell', lambda x: {
Line 307:         'total': '1', 'free': '1'})
This actually fixes the test on real NUMA machines.
Line 308:     def test_getNumaTopology(self):
Line 309:         capsData = self._readCaps("caps_libvirt_intel_i73770_nosnap.out")
Line 310:         result = caps.getNumaTopology(capsData)
Line 311:         # only check cpus, memory does not come from file


-- 
To view, visit https://gerrit.ovirt.org/53091
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b5594a71047aae53374e4af5da95e3cd56f3835
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list