Change in vdsm[master]: Dynamic load of supervdsm_api funcs

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon Feb 8 08:38:50 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: Dynamic load of supervdsm_api funcs
......................................................................


Patch Set 8: Code-Review-1

(1 comment)

Please provide tests to cover to logic that you introduce here.

https://gerrit.ovirt.org/#/c/52875/8/vdsm/supervdsm_api/hwinfo.py
File vdsm/supervdsm_api/hwinfo.py:

Line 23: api_
Why do we need this prefix. We already keep this file in specific directory. It would be enough to load public functions.


-- 
To view, visit https://gerrit.ovirt.org/52875
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67a1c349c15a03ba54788ffafd0c5b9d30ff7037
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list