Change in vdsm[master]: migration: added support for convergance schedule

fromani at redhat.com fromani at redhat.com
Mon Feb 8 08:29:38 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: migration: added support for convergance schedule
......................................................................


Patch Set 12: Code-Review+2

(1 comment)

ok seems good

https://gerrit.ovirt.org/#/c/46940/12/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 342:                         self._startUnderlyingMigration(time.time())
Line 343:                         self._finishSuccessfully()
Line 344:                 except libvirt.libvirtError as e:
Line 345:                     if (e.get_error_code() ==
Line 346:                             libvirt.VIR_ERR_OPERATION_ABORTED):
> not sure why I didn't noticed before, but this looks unnecessary.
ok, it was about the line lenght; note to self: drink coffee BEFORE review not after.
Line 347:                         self.status = response.error(
Line 348:                             'migCancelErr', message='Migration canceled')
Line 349:                     raise
Line 350:         except MigrationDestinationSetupError as e:


-- 
To view, visit https://gerrit.ovirt.org/46940
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I989cff12d08ef1cab36bd10df7daaa999a8dac14
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list