Change in vdsm[master]: contrib: schema converter

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Sun Feb 7 19:37:11 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: contrib: schema converter
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.ovirt.org/#/c/52864/2//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2016-01-28 15:10:47 +0100
Line 4: Commit:     pkliczewski <piotr.kliczewski at gmail.com>
Line 5: CommitDate: 2016-02-05 13:56:09 +0100
Line 6: 
Line 7: contrib: schema converter
> you moved the parsing code. why?
I was unable to import it from the script so I moved it to a module so I can share it with the original script and the converter.
Line 8: 
Line 9: 
Line 10: Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92


https://gerrit.ovirt.org/#/c/52864/2/contrib/schema-converter
File contrib/schema-converter:

Line 323:     # make sure that types are first
Line 324:     data = commands
Line 325:     data['types'] = all_types
Line 326: 
Line 327:     f.write(yaml.dump(data, indent=4, width=80, default_flow_style=False, Dumper=Anchor))
> pep8 violation
Will check
Line 328: 
Line 329: 
Line 330: def main(args):
Line 331:     if len(args) < 2:


Line 336:     yaml_path = args[1]
Line 337: 
Line 338:     api = vdsmapi.get_api(json_path)
Line 339: 
Line 340:     with open(json_path) as f:
> check if it works with python3 coding . I needed to use io.open and specify
Will check and make sure that it works with python3
Line 341:         symbols = vdsmapi.read_schema_doc(f, api)
Line 342: 
Line 343:     with open(yaml_path, 'w') as f:
Line 344:         write_schema(f, symbols)


-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list