Change in vdsm[master]: adding dynamic_package_load util module for reuseability

ybronhei at redhat.com ybronhei at redhat.com
Sun Feb 7 18:20:51 UTC 2016


Yaniv Bronhaim has posted comments on this change.

Change subject: adding dynamic_package_load util module for reuseability
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/53016/3/lib/vdsm/dynamic_package_load.py
File lib/vdsm/dynamic_package_load.py:

Line 16: #
Line 17: # Refer to the README and COPYING files for full details of the license
Line 18: #
Line 19: import os
Line 20: import re
> come to think about it - there's https://docs.python.org/2.7/library/pkguti
I can use that if you prefer, but I like this implementation as well
Line 21: 
Line 22: 
Line 23: def _import_module(abspkg, mname):
Line 24:     """return imported module mname from abspkg."""


Line 33: set
> frozenset, as this set is not expected to change
done


-- 
To view, visit https://gerrit.ovirt.org/53016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie87a63cfabb32c15376fbb1a06bbb20f3941f220
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list