Change in vdsm[master]: virt: recovery: use proper os.path functions
danken at redhat.com
danken at redhat.com
Sun Feb 7 14:44:02 UTC 2016
Dan Kenigsberg has posted comments on this change.
Change subject: virt: recovery: use proper os.path functions
......................................................................
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/53053/1/vdsm/virt/recovery.py
File vdsm/virt/recovery.py:
Line 219: except ValueError:
: # If file is missing type extention - ignore it
: pass
dead code, as splitext() always returns a two-tuple.
Line 219: except ValueError:
Line 220: # If file is missing type extention - ignore it
Line 221: pass
Line 222: else:
Line 223: if fileType == ".recovery" and vmId not in cif.vmContainer:
actaully,
for vmid in _find_vdsm_vms_from_files(cif):
rmFile etc
or am I missing something?!
Line 224: cif.log.debug("cleaning old file " + f)
Line 224: + f
going to (...%s", f) is favourable.
--
To view, visit https://gerrit.ovirt.org/53053
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I93935e32e4169efa8f03be1bfc1d7021374ee68e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list