Change in vdsm[master]: net: add documentation for setupNetworks rollback mechanism.

danken at redhat.com danken at redhat.com
Sun Feb 7 14:18:32 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: net: add documentation for setupNetworks rollback mechanism.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/50261/2/lib/vdsm/network/configurators/__init__.py
File lib/vdsm/network/configurators/__init__.py:

Line 33: from ..models import Bond, Bridge, hierarchy_vlan_tag, hierarchy_backing_device
Line 34: from ..sourceroute import StaticSourceRoute
Line 35: 
Line 36: 
Line 37: class RollbackIncomplete(Exception):
> Should we add a remark that currently this exception does not reach vdsm? (
You're welcome to add: "Note that it is never raised by the default ifcfg configurator"
Line 38:     """This exception is raised in order to signal API.Global that a call to
Line 39:     setupNetworks has failed and there are leftovers that need to be cleaned
Line 40:     up.
Line 41:     """


-- 
To view, visit https://gerrit.ovirt.org/50261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f7d66f9612ed6762fa80e7aa9e57d914dd65f34
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list