Change in vdsm[master]: service: change vdsm KillMode to mixed

danken at redhat.com danken at redhat.com
Sat Feb 6 10:49:37 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: service: change vdsm KillMode to mixed
......................................................................


service: change vdsm KillMode to mixed

When SIGTERM is sent to vdsm, automatically systemd sends the same signal
 to its childs processes, this can cause them to exit before vdsm closes
 fds to them properly.

Using mixed KillMode in .service will send SIGTERM only to main vdsm
service at first, sigkill will be sent to its children after a timeout.

http://www.freedesktop.org/software/systemd/man/systemd.kill.html

Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1189200
Signed-off-by: Yeela Kaplan <ykaplan at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/45038
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Dima Kuznetsov <dmitrykuzn at gmail.com>
Reviewed-by: Douglas Schilling Landgraf <dougsland at redhat.com>
Reviewed-by: Fabian Deutsch <fabiand at redhat.com>
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Tested-by: Yaniv Bronhaim <ybronhei at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M init/systemd/vdsmd.service.in
M vdsm.spec.in
2 files changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Fabian Deutsch: Looks good to me, but someone else must approve
  Douglas Schilling Landgraf: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Verified; Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dima Kuznetsov: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/45038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dmitrykuzn at gmail.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list