Change in vdsm[master]: net: Canonize dhcpv6 on API input

danken at redhat.com danken at redhat.com
Fri Feb 5 12:29:37 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: Canonize dhcpv6 on API input
......................................................................


net: Canonize dhcpv6 on API input

IPv6 dhcp is enabled by default, therefore, if the key is missing
from the network setup request, dhcp on ipv6 is left ON.

VDSM assumes a different default, which is ipv6 dhcp OFF.
To keep VDSM logic, a missing dhcpv6 key is converted to dhcpv6=False

Change-Id: I2b551f28ba143ca88efdbaec7771b7eba0608318
Signed-off-by: Edward Haas <edwardh at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/52989
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/network/canonize.py
M tests/netconfpersistenceTests.py
2 files changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/52989
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b551f28ba143ca88efdbaec7771b7eba0608318
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list