Change in vdsm[master]: Hook: ide2sata: To switch IDE disks to SATA

danken at redhat.com danken at redhat.com
Thu Feb 4 22:17:47 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: Hook: ide2sata: To switch IDE disks to SATA
......................................................................


Patch Set 7: Code-Review-1

(2 comments)

a doc nit, and a question

https://gerrit.ovirt.org/#/c/48450/7/vdsm_hooks/ide2sata/README
File vdsm_hooks/ide2sata/README:

Line 19: diskunmap
copy+paste typo, I presume.


Line 41: IDE disks
so why don't you convert virtio disks to SATA?


-- 
To view, visit https://gerrit.ovirt.org/48450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0088dae191cf4560a00ee62023a54f5ab746a3c9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Javier Coscia <ciudavitacos at gmail.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Javier Coscia <ciudavitacos at gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list