Change in vdsm[master]: xmlrpc: retry when flushing socket

ybronhei at redhat.com ybronhei at redhat.com
Thu Feb 4 14:35:29 UTC 2016


Yaniv Bronhaim has posted comments on this change.

Change subject: xmlrpc: retry when flushing socket
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/47637/5//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: m2crypto requires retry of write and we need to make sure that we do it
Line 10: once
Line 11: flushing data before closing a socket. In order to do so we need to move
Line 12: original implementation of IPXMLRPCRequestHandler#finish to our request
> but the implementation is from module as above
but if you want to find the code itself you need to dig in until getting to SocketServer.py , so better to specify that you override socketServer impl,  if someone want to check the origin code
Line 13: handler which inherits from IPXMLRPCRequestHandler.
Line 14: 
Line 15: 
Line 16: Bug-Url: https://bugzilla.redhat.com/1261255


-- 
To view, visit https://gerrit.ovirt.org/47637
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52dd6ad304a82ff6c8d3dff12a38269684abf055
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list