Change in vdsm[master]: xmlrpc: retry when flushing socket

ybronhei at redhat.com ybronhei at redhat.com
Thu Feb 4 14:14:53 UTC 2016


Yaniv Bronhaim has posted comments on this change.

Change subject: xmlrpc: retry when flushing socket
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/47637/5//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: m2crypto requires retry of write and we need to make sure that we do it
Line 10: once
Line 11: flushing data before closing a socket. In order to do so we need to move
Line 12: original implementation of IPXMLRPCRequestHandler#finish to our request
finish method comes from /usr/lib64/python2.7/SocketServer.py
Line 13: handler which inherits from IPXMLRPCRequestHandler.
Line 14: 
Line 15: 
Line 16: Bug-Url: https://bugzilla.redhat.com/1261255


https://gerrit.ovirt.org/#/c/47637/5/vdsm/rpc/bindingxmlrpc.py
File vdsm/rpc/bindingxmlrpc.py:

Line 298:                             # such as the local error ECONNABORTED.
Line 299:                             break
Line 300:                         except SSL.SSLError as e:
Line 301:                             if e.message == 'bad write retry':
Line 302:                                 continue
if e.message != 'bad write retry':
   break


should be enough for that loop
Line 303:                             else:
Line 304:                                 break
Line 305: 
Line 306:                 self.wfile.close()


-- 
To view, visit https://gerrit.ovirt.org/47637
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52dd6ad304a82ff6c8d3dff12a38269684abf055
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list