Change in vdsm[master]: net: IP DHCP detection

danken at redhat.com danken at redhat.com
Thu Feb 4 12:01:31 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: net: IP DHCP detection
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

tiny comments. please have phoracek review his hook code

https://gerrit.ovirt.org/#/c/53076/2/lib/vdsm/netinfo/dhcp.py
File lib/vdsm/netinfo/dhcp.py:

Line 70: ipaddrs, dev
argument name and order: iface, ipaddr


Line 75: 'permanent' not in ipaddr['flags']
could be nicer to define

  netlink.addr.is_permanent()

(similar usage in netinfo/addresses.py to is_primary)


-- 
To view, visit https://gerrit.ovirt.org/53076
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d0396610822e3a41d44f37346ee1aad71d569d1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list