Change in vdsm[master]: net: Clean netinfo.__init__ and migrate to cache
edwardh at redhat.com
edwardh at redhat.com
Thu Feb 4 11:08:00 UTC 2016
Edward Haas has posted comments on this change.
Change subject: net: Clean netinfo.__init__ and migrate to cache
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/53007/3/lib/vdsm/netinfo/cache.py
File lib/vdsm/netinfo/cache.py:
Line 157: def ifaceUsed(iface):
Line 158: """Lightweight implementation of bool(Netinfo.ifaceUsers()) that does not
Line 159: require a NetInfo object."""
Line 160: if os.path.exists(os.path.join(netinfo.NET_PATH, iface, 'brport')):
Line 161: return True
> please move the # Is it a port
Done
Line 162: for linkDict in nl_link.iter_links():
Line 163: if linkDict['name'] == iface and 'master' in linkDict: # Is it a slave
Line 164: return True
Line 165: if linkDict.get('device') == iface and linkDict.get('type') == 'vlan':
--
To view, visit https://gerrit.ovirt.org/53007
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I892bb86fe9a8580d9028ca7759d27967e55d85f7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list